Update develocity configuration #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
update-develocity-config
branch
from
681091c to
f67a8ee
Compare
trask
commented
Nov 23, 2024
Comment on lines
-75
to
-80
| develocity.testRetry { | ||
| // You can see tests that were retried by this mechanism in the collected test reports and build scans. | ||
| if (System.getenv().containsKey("CI") || rootProject.hasProperty("retryTests")) { | ||
| maxRetries.set(5) | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
we may be able to keep this, but we won't be able to see flaky tests across runs anymore, so maybe better to remove it (at least in this repo)
Contributor
There was a problem hiding this comment.
I think removing it is fine, if flaky tests are an issue we can work on them or reintroduce the retry.
laurit
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO delete
GRADLE_ENTERPRISE_ACCESS_KEYgithub action secret after merging this